Guess Who? - Dog edition by Anna Robertsson #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on, added counter and sound effect
IdahCollin
approved these changes
Sep 11, 2023
| } | ||
|
|
||
| // It'll filter the characters array and redraw the game board. | ||
| // Filter the characters array and redraw the game board by determining what is the category, and if it's to keep or remove based on the keep variable | ||
| const filterCharacters = (keep) => { |
There was a problem hiding this comment.
Good job on changing the game to dogs! Do you think line 435-512 might be good to comment a bit more, just short ones to make eg. next developer looking at this find things a bit easier? Like:
// Fur color
// Ears
etc.?
| } | ||
|
|
||
| // Invokes a function to redraw the board with the remaining dogs | ||
| generateBoard(charactersInPlay) |
There was a problem hiding this comment.
As we've been doing the same project I compared to mine, I have just used the
generateBoard()
does that work for your code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started by looking through the material for the week and then started to code. I think the instructions of the project and the starter code were a good help to get started. I used a bit of Stack Overflow but mainly chatGPT when I got stuck. I also double checked with chatGPT if my code looked good. I had great help from my team mates through our discussions.
If I had more time I would rename the characters in the code when they are called 'person' to 'dogs' because it would make more sense since I switched to a dog theme. However 'person' is used in variables and values and therefore I didn't change it now since there was a risk something might not work in the code and I then wouldn't have time to fix it.
Please visit:
https://project-guess-who-anna-robertsson.netlify.app