Guess Who: Middle-Earth Quest / Olga #342
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colognia
reviewed
Sep 12, 2023
There was a problem hiding this comment.
Good pull request description and the code does not have bugs.
-
player not working, mp3 path seems to be wrong
-
elements in aside not all visible in viewport, because of big gap
-
For the commits the description should be more informative and containing a body about details -> https://cbea.ms/git-commit/
-
all tasks from 1-5 are fullfilled
-
bonustask: working restart button, properties of items changed
-
added new value to dropdown for user choice
-
nice extensive costum styling to make it unique
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my Lord of the Rings themed guess who project called Guess Who: Middle-Earth Quest!
Your job is to guess the right character to save Middle-Earth.
Link to the deployed site: https://middle-earth-quest.netlify.app/
Note: Unfortunately the html audio player I put to the corner does not work with the deployed site :(
So it is highly suggested that you listen to some LOTR tunes while playing this game.