Isaac_Kamran_Guess_Who #340
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isaackamran
commented
Sep 10, 2023
There was a problem hiding this comment.
Deploy website: https://isaac-kamran-guess-who.netlify.app/
|
The game works as required. The code is written clearly and can be understood. However, I would remove the excess comments which are like Technigo commands - because they are unnecessary (I am talking about the example of entering the code with filter ()). But overall the code is well written. |
Comment on lines
360
to
+371
| const checkMyGuess = (personToCheck) => { | ||
| if (personToCheck === secret["name"]) { | ||
| questions.style.display = "flex" | ||
| winOrLose.style.display = "flex" | ||
| board.style.display = "none" | ||
| winOrLoseText.innerHTML = "WOOHOO! YOU WON!" | ||
| } else { | ||
| questions.style.display = "flex" | ||
| winOrLose.style.display = "flex" | ||
| board.style.display = "none" | ||
| winOrLoseText.innerHTML = "OH NO! YOU LOST!" | ||
| } |
There was a problem hiding this comment.
This code looks nice. Can you tell me why you use flex? I'm curious because I have it done differently, but I'd like to know what you had in mind when writing this code :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished all steps.