Project Guess Who - Week 3 Julia #336
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verawitting
reviewed
Sep 11, 2023
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Project Name</title> |
verawitting
reviewed
Sep 11, 2023
| padding: 5vw; | ||
| align-items: center; | ||
| box-sizing: border-box; | ||
| background: linear-gradient(90deg, lightsalmon, #c58fc9, #48D1CC); |
verawitting
reviewed
Sep 11, 2023
| charactersInPlay = CHARACTERS; | ||
| generateBoard(); // Invokes generateBoard function. | ||
| setSecret(); // Invokes setSecret function. | ||
| filterBtn.disabled = true; // Disables the "Find Out" button before the player has selected an option from the selection menu. |
There was a problem hiding this comment.
nice solution! Also, good explanation in comments of what's going on!
verawitting
reviewed
Sep 11, 2023
| const category = questions.options[questions.selectedIndex].parentNode.label | ||
| filterBtn.disabled = false; // Enables the "Find Out" button when a selection has been made. | ||
| filterBtn.style.opacity = "1"; // Opacity set to default on the find out button. | ||
| const category = questions.options[questions.selectedIndex].parentNode.label; // This variable stores what option group the question belongs to. | ||
|
|
||
| // This variable stores what option group (category) the question belongs to. |
There was a problem hiding this comment.
I think maybe you left the already existing comment, and wrote a new one that explains the same piece of code? Makes it a little confusing
verawitting
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Clear code overall! It's easy to follow, due to comments and structure. I think you seem to have a quite consistent naming of variables, super! And most important, to me it seems to be running perfectly. As I kind of expect from the CSS pro that you are, you added some nice css, fun! As you mentioned to me before, you have started a new version of the page, so my comments might be a little all over, sorry for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://project-guess-who-julia.netlify.app/