Elins Guess who? #332
Elins Guess who? #332
Conversation
…work on others and glasses though
There was a problem hiding this comment.
Nice job, Elin! Your guess who game works perfect for me and in my opinion you have all of the requirements :-) I'm sure you could tackle some of the stretch goals if you had time. Perhaps using more comments would make reading your code smoother (but perhaps I comment too much!!). You had good function and variable names which made sense and well set out if statements.
Your find out button doesn't work when you first load the page (need to change your select dropdown first), perhaps making a disabled option that is first displayed eg. "Choose an option here..." would force the user to chose before hitting find out on brown eyes first go. Well done for this week :-)
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Project Name</title> |
There was a problem hiding this comment.
Would be cool to write something like "Guess Who?" here
| // Randomly select a person from the characters array and set as the value of the variable called secret | ||
| const setSecret = () => { | ||
| secret = charactersInPlay[Math.floor(Math.random() * charactersInPlay.length)] | ||
|
|
||
| //console.log(`secret person is ${secret.name}`); //helped me to see who the secret person is. |
There was a problem hiding this comment.
I did the same here! and I kept it in my code too, it was vital to have this information when debugging and testing
|
|
||
| if (category === 'hair' || category === 'eyes') { | ||
| keep = value === secret[category]; |
There was a problem hiding this comment.
I don't really understand this line, with 2 equals = values, but it works!
| // If the player wants to guess, invoke the checkMyGuess function. | ||
| const isConfirmed = confirm(`Are you sure you want to guess that ${personToConfirm} is the secret person?`); | ||
|
|
||
| if (isConfirmed) { |
There was a problem hiding this comment.
i'm wondering if this if statement needs what happens if they do not confirm?
| } else { | ||
| winOrLose.style.display = "flex"; | ||
| board.style.display = 'none'; | ||
| winOrLoseText.innerHTML += `<h1>Your guess is unfortunately wrong 😞 Do you wanna try again?</h1>` |
There was a problem hiding this comment.
this is great, works well, is succinct and easy to understand
| start(); | ||
|
|
||
| const replay = () => { | ||
| location.reload(); //The location.reload refreshes the page, which was a easy solution to make the game start again. |
There was a problem hiding this comment.
nice one! I have not used .reload before, you are right it is an easy solution
| restartButton.addEventListener('click', start) | ||
| restartButton.addEventListener('click', start); //resets the board when the restart button is clicked. | ||
|
|
||
| questions.addEventListener('click', selectQuestion); //Does this work? Error in console on website. |
There was a problem hiding this comment.
im also wondering about this, doesn't select question get called when you click the findout button?
Here's my Guess who game! 😄