Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Who's there? Ulrika Gålnander #330

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Who's there? Ulrika Gålnander #330

wants to merge 4 commits into from

Conversation

Shiqwan
Copy link

@Shiqwan Shiqwan commented Sep 10, 2023

Copy link

@malinlunde malinlunde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first thing I did was to try out the game, it worked perfectly clean. You are using playful language that interact with the player in a fun and easy to understand way. The code are pretty similar to my own and even others I looked at, it's not much to say there, even do you struggled it actually works, it is easy to read and it is easy to follow because of the comments that you made that are very clear. I think you made a very good job.

let secret
let currentQuestion
let charactersInPlay
let secret; //will be the secret person object

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All code looks clean and are easy to read and your comments makes it very easy to understand


// This function should be invoked when you click on 'Find Out' button.
// This part I still don't understand and have struggled a lot with

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though you struggled it actually works and that is the goal. I tried your game and I couldn't see anything that didn't work

winOrLoseText.innerHTML = `CONGRATULATIONS! <br>
YOU PICKED THE RIGHT ONE!`;
} else {
winOrLoseText.innerHTML = `Aaah dang it, that was the wrong one!`;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your language makes the game interact with the player in a fun way! Playable english!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants