Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final project-ParkHive #59

Open
wants to merge 130 commits into
base: main
Choose a base branch
from
Open

Final project-ParkHive #59

wants to merge 130 commits into from

Conversation

trista1987
Copy link

Netlify link

Frontend: https://parkhive.netlify.app/
Backend: https://parkhive.onrender.com

Collaborators

[Citronskal, trista1987]

Copy link

@AntonellaMorittu AntonellaMorittu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Yia and Trista, stort grattis! 🎓

Congrats for completing the bootcamp and shipping a fantastic final project! I'm really impressed with your result, the app looks very professional and ready to be used by real users, well done!

I like how you developed an app with a smooth flow, clear UI and good UX, I love the animations for loading state and small details like the button to scroll to top, very nice touch! You worked well also when writing your code, nicely formatted and structured, both in the backend and the frontend.
In this final project, we asked you to plan your bigger project work, further deepen your knowledge in web development and finally explore new technologies and you definitely succeeded in all these aspects!
You nailed responsiveness as well, shipping such result in only 3 weeks this is truly admirable. You should be PROUD!
Now, here's some adjustments to take into consideration to improve the quality of your app.

Fixes to meet the basic requirements:

  • Accessibility: should score at least 95 on Lighthouse
  • deploy routes on Netlify

Tips to improve your app:

  • links open to a new tab
  • social media links don’t have a link - better to hide part of the app in production unless they have a functionality
  • make the map for the park bigger to fit in some empty space in desktop screens

Please fix the accessibility aspect and deploy your routes. Once again my congratulations for your hard work, you're ready to be graduated developers now ⭐

@trista1987
Copy link
Author

Dear Yia and Trista, stort grattis! 🎓

Congrats for completing the bootcamp and shipping a fantastic final project! I'm really impressed with your result, the app looks very professional and ready to be used by real users, well done!

I like how you developed an app with a smooth flow, clear UI and good UX, I love the animations for loading state and small details like the button to scroll to top, very nice touch! You worked well also when writing your code, nicely formatted and structured, both in the backend and the frontend. In this final project, we asked you to plan your bigger project work, further deepen your knowledge in web development and finally explore new technologies and you definitely succeeded in all these aspects! You nailed responsiveness as well, shipping such result in only 3 weeks this is truly admirable. You should be PROUD! Now, here's some adjustments to take into consideration to improve the quality of your app.

Fixes to meet the basic requirements:

  • Accessibility: should score at least 95 on Lighthouse
  • deploy routes on Netlify

Tips to improve your app:

  • links open to a new tab
  • social media links don’t have a link - better to hide part of the app in production unless they have a functionality
  • make the map for the park bigger to fit in some empty space in desktop screens

Please fix the accessibility aspect and deploy your routes. Once again my congratulations for your hard work, you're ready to be graduated developers now ⭐

Hi Antonella!
Thanks for your suggetsions! 😁
I have added the deploy routes on Netilfy and Yia has changed accessibility. But we have got different accessibility score from our computers, the score is 96 from Yia's computer and the score is 95 from my computer. So we are not sure whether using different servers and locations will affect the score?

@Citronskal
Copy link

Hi Antonella, like Trista mentioned, we have made some small adjustments and accessibility is above 95 on both our devices.
Screenshot 2024-06-25 at 7 56 48 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants