Business site project #384
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please create a README-file where you put your Netlify link 😊 |
JennieDalgren
requested changes
Sep 28, 2024
Updated readme and pasted my netlify link
JennieDalgren
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Good job!
You are meeting all requirements.
In the future, make sure to not add any styling in the html file - put it into the css instead.
In the css it looks like all the texts are using font-family sans-serif. If you have these rules, you can put them on the whole body instead. Same goes with other styling that is repeated. Remember DRY coding is the best.
| <input type="email" id="email" name="email" placeholder="[email protected]" required> | ||
| <br> | ||
| <br> | ||
| <label style="margin-left: 10px;"> How would you like to be contacted?</label> <br> |
There was a problem hiding this comment.
add the styling in the css file in the future. No inline styling ❌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my business-site project