Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stars above #366

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Stars above #366

wants to merge 6 commits into from

Conversation

nella-x
Copy link

@nella-x nella-x commented Aug 30, 2024

Website with responsive design and a form that has different input types.
I've tried to keep the code as clean and clear as possible, with good HTML structure.

https://stars-above.netlify.app/

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nella, great job on creating this business site! Here comes some suggestions to think about going forward or tips to improve.

HTML

  • It's great to see that you’re using a <section> tag for the workshops. This makes your content more structured and easier for search engines to index. Consider using a <section> tag for the sale-box as well.
  • You’ve met the requirement of including multiple input types in your form. However, ensure that each input's attributes uses the correct quote characters. Comparison: vs ", can you see that the first one is skewed and the second is more straight? Sometimes when we copy code, we get the skewed ones, but it's a complete different character, so make sure to always use the straight ones. To update your project, mark any in Visual Studio Code and then do cmd + D (if you have Mac) to find all instances. That way you can easily replace them all. I think this will also "clean up" the response you get from HTTPBIN.

CSS

  • Nice font you've found, and I think the design choices are well thought through.
  • Ensure that your form is visually aligned with the rest of your website's design. Consider using padding, margins, and borders to make it stand out but remain cohesive with your overall design. A tip can be to try to align your elements to make it look nicer and make it more accessible.
  • Removing the body's default margin will make more space for our content as well as making it look nicer.

Keep up the good work ⭐

@nella-x
Copy link
Author

nella-x commented Sep 4, 2024

Hello! Thank you for the feedback, I have made som adjustments. Nothing big. I'm not sure if the changes I've made to the form is what you requested, but I think it looks better now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants