Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

[1.16.1] Recipe condition "tag" broken #159

Open
Sturmlilie opened this issue Aug 5, 2020 · 4 comments
Open

[1.16.1] Recipe condition "tag" broken #159

Sturmlilie opened this issue Aug 5, 2020 · 4 comments

Comments

@Sturmlilie
Copy link
Contributor

Sturmlilie commented Aug 5, 2020

The "tags" condition cannot be relied upon anymore. This expression in the testing lambda:

ItemTags.getContainer().getEntries()

always returns an empty map. I tried experimenting with a bit:

Set<Identifier> entries = ItemTags.method_29214(BlockTags.getContainer());

which gives me all vanilla-registered item tags at least, but no modded ones. This breaks eg. Blockus compatibility.

@Sturmlilie Sturmlilie changed the title [1.16.1] Recipe condition "tags" broken [1.16.1] Recipe condition "tag" broken Aug 5, 2020
@Sturmlilie
Copy link
Contributor Author

blockus_marble_tempfix.zip

Above is a datapack that temporarily fixes the compatibility (marble grinding) with blockus. Note that earlier report of problems with not being able to craft crude storage units from barrels is very likely also caused by this bug, as the recipes for blockus barrels -> storage unit aren't being loaded either.

@Linguardium
Copy link

make sure you are testing in production, there is a bug with tags in development mode where any tag file used will overwrite any other one (even with replace:false) meaning adding things to vanilla tags will replace those tags in dev only

@Sturmlilie
Copy link
Contributor Author

How is development mode defined? I mostly test my stuff by compiling to jar and launching the game from MultiMC

@Linguardium
Copy link

running from intellij for example. or from gradlew runclient.

running from multimc should work fine

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants