Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various toolset fixes and updates #8951

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

volyrique
Copy link
Contributor

@volyrique volyrique commented Apr 28, 2024

  • Fix the MongoDB Docker image
  • Update the toolset Docker images to Ubuntu 24.04
  • Update Dool to version 1.3.1
  • Fix any warnings that are printed by the toolset scripts

Copy link
Contributor

The following frameworks were updated, pinging maintainers:
trillium: @jbr

@volyrique volyrique force-pushed the docker branch 2 times, most recently from a91f7a7 to 839d52f Compare May 3, 2024 20:03
@volyrique volyrique changed the title Update the toolset Docker images to Ubuntu 24.04 Various toolset fixes and updates May 3, 2024
* Fix the MongoDB Docker image
* Update the toolset Docker images to Ubuntu 24.04
* Update Dool to version 1.3.1
* Fix any warnings that are printed by the toolset scripts
@volyrique
Copy link
Contributor Author

@NateBrady23 The MongoDB Docker image created by the toolset is broken and all implementations that depend on it will fail in the current continuous benchmarking run, 662d8347-d314-4010-857e-fee18302b327 (some failures are already visible); the same holds true for any GHA runs. The change to toolset/databases/mongodb/create.js is the fix.

I have pushed several revisions of this PR, and as far as I can tell the test failures have either been expected (because the same implementations had failed in the continuous benchmarking environment) or have been due to running out of disk space.

@NateBrady23
Copy link
Member

@volyrique Thank you so much for taking care of this!

@NateBrady23 NateBrady23 merged commit bda05af into TechEmpower:master May 6, 2024
24 of 42 checks passed
@volyrique volyrique deleted the docker branch May 6, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants