DRAW-440 게임 시작 시 DB 에서 닉네임 조회 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunwoongH
reviewed
Nov 10, 2024
Comment on lines
-27
to
+29
| return userUseCase.getUserDetail(user.userId).toResponse() | ||
| val userInfo = userUseCase.getUserDetail(user.userId) ?: throw NotFoundUserException |
There was a problem hiding this comment.
P5
예외를 서비스에서 던지는 건 어떨까요?
There was a problem hiding this comment.
조회 관련하여 throw는 최종적으로 사용하는 곳에서 던지는 것이 좋다고 생각이 듭니다.
유저가 존재하는지 여부를 체크하고 싶으면 위 케이스는 try catch로 처리를 해야하는데 그럼 어떤 Exception이 던져지는지 CheckedException이 아닌 이상 확인이 어렵기에 변경에도 민감해질 것 같습니다.
| @@ -155,7 +157,8 @@ internal abstract class BaseWebSocketHandler( | |||
| private fun getUser(session: WebSocketSession): User? { | |||
| val userId = getUserId(session) ?: return null | |||
| val encodedNickname = session.getHeader(HEADER_NICKNAME) ?: return null | |||
| val nickname = URLDecoder.decode(encodedNickname, StandardCharsets.UTF_8.toString()) | |||
| val user = userUseCase.getUserDetail(userId) | |||
| val nickname = user?.name ?: URLDecoder.decode(encodedNickname, StandardCharsets.UTF_8.toString()) | |||
There was a problem hiding this comment.
P5
헤더로 닉네임 전달 받을 때, 인코딩된 값을 전달 받게 되는 건가요?
There was a problem hiding this comment.
넹 헤더에 한글이 안들어가더라구요
comforest
force-pushed
the
feature/DRAW-440
branch
from
74fab18 to
cdc45b1
Compare
comforest
force-pushed
the
feature/DRAW-440
branch
from
cdc45b1 to
408bd44
Compare
SunwoongH
changed the title
SunwoongH
approved these changes
Nov 11, 2024
comforest
force-pushed
the
feature/DRAW-440
branch
from
70ae716 to
0432666
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Jira ✔
Description ✔
PR Rule ✔
P1: 꼭 반영해주세요 (Request changes)
P2: 적극적으로 고려해주세요 (Request changes)
P3: 웬만하면 반영해 주세요 (Comment)
P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
P5: 그냥 사소한 의견입니다 (Approve)