-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAW-347 WebSocket / Core & Domain 의존성 분리 리팩터링 Base #1
Open
SunwoongH
wants to merge
154
commits into
develop
Choose a base branch
from
feature/DRAW-347
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRAW-348 Domain & Core 에서 WebSocket 관련 내용 제거 - 1차
DRAW-350 Package 수정
DRAW-351 Session 객체 WebSocket으로 이관
DRAW-352 Waiting Queue 리팩토링
DRAW-415 게스트 로그인 연동 API 구현
DRAW-428 소셜 로그인 이메일 가져오기
# Conflicts: # domain/src/main/kotlin/com/xorker/draw/exception/XorkerException.kt
DRAW-412 이미 게임중인 유저 중복 참여 방지
DRAW-440 게임 시작 시 DB 에서 닉네임 조회
DRAW-416 빠른 매칭 유저 중복 등록 오류 수정
DRAW-443 탈퇴 시 소셜 플랫폼 정보 제거 로직 추가
DRAW-442 탈퇴 유저 조회 필터링 로직 추가
DRAW-387-1 Google Login Ios 지원
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Jira ✔
Description ✔
PR Rule ✔
P1: 꼭 반영해주세요 (Request changes)
P2: 적극적으로 고려해주세요 (Request changes)
P3: 웬만하면 반영해 주세요 (Comment)
P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
P5: 그냥 사소한 의견입니다 (Approve)