Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prepush): adjusts pre-commit to run tests in shell #181

Merged
merged 9 commits into from
Nov 13, 2023

Conversation

esparr
Copy link
Collaborator

@esparr esparr commented Nov 2, 2023

Pull Request Template

1. Targeted Issue

Issue #167
Issue #169

2. Overview of Solution

This PR addresses two tickets, see above.

I added in the pre-push documentation and also am offering up a solution to demonstrating outputs without compromising the ability to easily copy code from the README.md on Github. I am open to feedback on the implementation.

This also solves an issue I was experiencing with Github Desktop when running pre-push before pushing up to Github. The solution was to make sure the tests were running in pipenv shell. @jimbandrews assisted with this solution

Other changes:
Cleans up lingering linting issues

3. Tools Used

pipenv run

4. Testing Strategy

Tried to run this with Github Desktop and from shell in terminal. Both successfully ran the tests.

5. Future Implications

6. Screenshots

Preview mode:
Screen Shot 2023-11-02 at 3 04 22 PM

Markdown:
Screen Shot 2023-11-02 at 3 05 00 PM

7. Code Reviewers

@jimbandrews @GitLukeW


Before you go...

  • I have linked the relevant issue
  • I have provided an overview of my solution
  • I have shared the tools I've used
  • I have outlined my testing strategy
  • I have considered future implications of my changes
  • I have included relevant screenshots
  • I have kept my team in the loop

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GitLukeW During the process of debugging, I uninstalled and reinstalled celery. When I did this, I also ran pipenv install and it looks like it updated boto3 as well. Do you think this is going to cause an issue? If so I can work on reverting it.

Copy link
Contributor

@jimbandrews jimbandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out locally, and it works. Good catch!

Copy link
Contributor

@GitLukeW GitLukeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this has merge conflicts from the previous PR.

Copy link
Contributor

@GitLukeW GitLukeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GitLukeW GitLukeW merged commit 4a3ba1e into staging Nov 13, 2023
@GitLukeW GitLukeW deleted the chore/issue-167/prepush-precommit-docs branch November 13, 2023 19:37
@esparr esparr linked an issue Nov 14, 2023 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pre-push precommit instructions to README.md
3 participants