Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated confirmation emails to use the same jitsi meeting for mentors… #117

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

nzeager
Copy link
Member

@nzeager nzeager commented Jul 20, 2023

… and mentees

Pull Request Template

1. Targeted Issue

Confirmation emails were sending a different jitsi meeting to mentors and mentees.

Issue #90

2. Overview of Solution

Instead of creating a meeting in models.py for the mentor/mentee emails, we moved it to views.py to create a single meeting. We called the create_meeting_link() function and passed that link into the functions to send each email.

3. Tools Used

Python, Django

4. Testing Strategy

Set up new session to check if both users got the same meeting invite

5. Future Implications

n/a

6. Screenshots

n/a

7. Code Reviewers

@GitLukeW


Before you go...

  • I have linked the relevant issue
  • I have provided an overview of my solution
  • I have shared the tools I've used
  • I have outlined my testing strategy
  • I have considered future implications of my changes
  • I have included relevant screenshots
  • I have kept my team in the loop

Big high-fives for your incredible pull request! We're thrilled to have you as a contributor! Our team will dig into your proposed changes and give you some feedback or merge them if they're good to go. Your contributions mean the world to us!

@nzeager nzeager requested a review from GitLukeW July 20, 2023 16:36
Copy link
Contributor

@GitLukeW GitLukeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Tested setting up sessions and confirming to ensure the emails are being sent and that they're the same message ID. Everything looks good. Code approved! 🙌

Thank you!

@GitLukeW GitLukeW merged commit 451b248 into main Jul 20, 2023
2 checks passed
@GitLukeW GitLukeW deleted the email-jitsi-invite branch July 20, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants