Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ArchiveSessionView to filter objects with end time that has p… #113

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

nzeager
Copy link
Member

@nzeager nzeager commented Jul 11, 2023

…assed

Pull Request Template

1. Targeted Issue

See above.

2. Overview of Solution

Updated logic on line 381.

3. Tools Used

n/a

4. Testing Strategy

Went over code with other user.

5. Future Implications

n/a

6. Screenshots

n/a

7. Code Reviewers

@GitLukeW


Before you go...

  • I have linked the relevant issue
  • I have provided an overview of my solution
  • I have shared the tools I've used
  • I have outlined my testing strategy
  • I have considered future implications of my changes
  • I have included relevant screenshots
  • I have kept my team in the loop

Big high-fives for your incredible pull request! We're thrilled to have you as a contributor! Our team will dig into your proposed changes and give you some feedback or merge them if they're good to go. Your contributions mean the world to us!

@nzeager nzeager requested a review from GitLukeW July 11, 2023 16:25
Copy link
Contributor

@GitLukeW GitLukeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for switching this over!

@GitLukeW GitLukeW merged commit b2f7cdd into main Jul 11, 2023
2 checks passed
@GitLukeW GitLukeW deleted the MM-58 branch July 11, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants