-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(prepush): adjusts pre-commit to run tests in shell #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GitLukeW During the process of debugging, I uninstalled and reinstalled celery. When I did this, I also ran pipenv install and it looks like it updated boto3 as well. Do you think this is going to cause an issue? If so I can work on reverting it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested out locally, and it works. Good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this has merge conflicts from the previous PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Pull Request Template
1. Targeted Issue
Issue #167
Issue #169
2. Overview of Solution
This PR addresses two tickets, see above.
I added in the pre-push documentation and also am offering up a solution to demonstrating outputs without compromising the ability to easily copy code from the README.md on Github. I am open to feedback on the implementation.
This also solves an issue I was experiencing with Github Desktop when running pre-push before pushing up to Github. The solution was to make sure the tests were running in pipenv shell. @jimbandrews assisted with this solution
Other changes:
Cleans up lingering linting issues
3. Tools Used
pipenv run
4. Testing Strategy
Tried to run this with Github Desktop and from shell in terminal. Both successfully ran the tests.
5. Future Implications
6. Screenshots
Preview mode:
Markdown:
7. Code Reviewers
@jimbandrews @GitLukeW
Before you go...