Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding of secret keys for database #78

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

gmemstr
Copy link
Contributor

@gmemstr gmemstr commented Jan 23, 2024

I currently use the the CrunchyData Postgres Operator in my cluster, which provisions secrets for PostgreSQL users with the username and password. These contain keys that cannot be modified (from what I can tell), so this change allows the value to be overridden.

Before:

secret: postgres-connection-details

After:

secret:
  name: postgres-connection-details
  username: user
  password: pass

@gmemstr gmemstr requested a review from samip5 as a code owner January 23, 2024 16:01
Copy link
Collaborator

@samip5 samip5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change log annotation is missing from Chart.yaml at least.

@samip5
Copy link
Collaborator

samip5 commented Jan 23, 2024

Also this should be a major bump, due to incompatible backwards compatibility if one uses that secret definition like I actually do.

@gmemstr
Copy link
Contributor Author

gmemstr commented Jan 23, 2024

Good point, will update!

@gmemstr gmemstr force-pushed the database-secret-keys branch 3 times, most recently from 692b383 to 7f45d46 Compare January 23, 2024 17:36
@gmemstr gmemstr requested a review from samip5 January 23, 2024 23:22
Copy link
Collaborator

@samip5 samip5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint failure in values.yaml: Error: 102:14 [trailing-spaces] trailing spaces

@gmemstr gmemstr force-pushed the database-secret-keys branch from 7f45d46 to 50c7d96 Compare January 24, 2024 09:29
@gmemstr gmemstr requested a review from samip5 January 24, 2024 09:29
@samip5 samip5 merged commit cfec6a8 into TeamPiped:main Jan 24, 2024
6 checks passed
@samip5
Copy link
Collaborator

samip5 commented Jan 26, 2024

@gmemstr Are you aware of these errors?

Error: template: piped/templates/backend/configmap.yaml:68:64: executing "piped/templates/backend/configmap.yaml" at <.Values.backend.config.database.secret.name>: can't evaluate field name in type interface {}

When secret is defined, but the optional things are not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants