Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/101 #102

Merged
merged 5 commits into from
Jan 9, 2018
Merged

Feature/101 #102

merged 5 commits into from
Jan 9, 2018

Conversation

st98
Copy link
Collaborator

@st98 st98 commented Jan 9, 2018

@st98 st98 requested a review from HayatoDoi January 9, 2018 08:56
@HayatoDoi
Copy link
Member

Flag Submissionって書くなら、Flagってところ消してもいいと思う。

image

@hiww
Copy link
Member

hiww commented Jan 9, 2018

個人的にはs/Flag Submission/Answer
にした方がわかりやすいと思った。
よく見かける感じだし？

@st98
Copy link
Collaborator Author

st98 commented Jan 9, 2018

🙏
どう表現するか悩んでたんですが、確かに Answer の方が分かりやすいですね。
ラベルについても、文面は変わりますが見出しがあって冗長かなあという感じなので変えておきます。

@hiww
Copy link
Member

hiww commented Jan 9, 2018

👍

HayatoDoi
HayatoDoi approved these changes Jan 9, 2018
View reviewed changes
Copy link
Member

@HayatoDoi HayatoDoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良いと思います。

@st98 st98 merged commit 602ef94 into dev Jan 9, 2018
@st98 st98 deleted the feature/101 branch January 9, 2018 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HayatoDoi HayatoDoi HayatoDoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@st98 @HayatoDoi @hiww