-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ch.21): custom recipe. #67
Open
3TUSK
wants to merge
3
commits into
bleeding
Choose a base branch
from
feat/custom-recipe
base: bleeding
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3TUSK
added
Type: New Content
Requesting new contents. This also applies to Pull Request.
Status: Reviewing
This is finished; we are reviewing it.
labels
Mar 23, 2020
|
不提一下 |
SeraphJACK
reviewed
Mar 24, 2020
@liach 就是因为这个。我更担心有人用这个把所有合成的注册全写代码里…… |
Apparently it is also used in sorting? Don't have time to verify but it is not something important either.
也可以介绍一下json recipe在registry event分发之前就已经加载了,而且registry event里面注册的recipe好像不能覆盖json读的recipe,不知道有没有意义 |
|
SeraphJACK
requested changes
Apr 24, 2020
@Override | ||
public NonNullList<Ingredient> getIngredients() { | ||
// 返回该合成的输入。 | ||
return NonNullList.create(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
用 getContainerItem
做个简单的示范?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: Reviewing
This is finished; we are reviewing it.
Type: New Content
Requesting new contents. This also applies to Pull Request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis / 简介
自定义合成。
Description / 详细说明
介绍了如何实现类似原版工具修复、地图扩展等有特殊逻辑的合成。
Justification / 理由
之前说好的把这个 https://www.mcbbs.net/thread-888719-2-2.html 里的回答搬过来一直在鸽。
Remarks / 备注
目录已经有这个了所以就没再动
SUMMARY.md
。