Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommended resources #2

Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
179b764
[#1713] added mock up display of recommended resouces
S-Warmenhoven Apr 6, 2020
d0b3041
[#1713] created More link to redirect to Resources Index Page
S-Warmenhoven Apr 6, 2020
25f3e09
[#1713] display all resources on moments show page]
S-Warmenhoven Apr 6, 2020
dc7324e
[#1713] changed resources' names into links
S-Warmenhoven Apr 6, 2020
20a8a14
[#1713] limit resources display to 3
S-Warmenhoven Apr 6, 2020
8dd6ec7
[#1713] created ResourceRecommendation class and method
S-Warmenhoven Apr 7, 2020
8c77f7b
[#1713] match resource tag with moment name, why, and fix
S-Warmenhoven Apr 8, 2020
f8592bf
[#1713] match resource tag with moment category name and description
S-Warmenhoven Apr 8, 2020
7458bbf
[#1713] match resource tag with moment strategy name and description
S-Warmenhoven Apr 8, 2020
39c7102
[#1713] match resource tag with moment mood name and description
S-Warmenhoven Apr 8, 2020
d0f4959
[#1713] refactored descriptions to account for html tags
S-Warmenhoven Apr 8, 2020
ebb575d
[#1713] added gsub! to account for special characters but still need …
S-Warmenhoven Apr 8, 2020
410e72b
[#1713] fixed gsub functionality for moment_keywords and resource_tags
S-Warmenhoven Apr 8, 2020
319fab3
[#1713] rubocop cleanup
S-Warmenhoven Apr 9, 2020
391ca8a
[#1713] refactored code to shorten resources method
S-Warmenhoven Apr 9, 2020
8f86346
[#1713] removed unnecessary variables
S-Warmenhoven Apr 9, 2020
9d67ddc
[#1713] modified resource tags to account for underscores
S-Warmenhoven Apr 9, 2020
ad42eb9
[#1713] shortened lines of code as per rubocop
S-Warmenhoven Apr 9, 2020
b6f3904
[#1713] refactored resource method as per rubocop standards
S-Warmenhoven Apr 10, 2020
2eb8656
[#1713] Changed JSON parse format to match PagesConcern format as per…
S-Warmenhoven Apr 13, 2020
dd50fa9
[#1713] removed unnecessary comments
S-Warmenhoven Apr 13, 2020
bd535d6
[#1713] moved unexposed methods to private
S-Warmenhoven Apr 13, 2020
aef55a9
[#1713] refactored .map & .flatten to use .flat_map instead
S-Warmenhoven Apr 13, 2020
10300a3
[#1713] Update app/services/resource_recommendation.rb
S-Warmenhoven Apr 13, 2020
7690cc8
[#1713] refactor to use select method instead of conditional
S-Warmenhoven Apr 13, 2020
ebb6bac
[#1713] resolved merge conflict
S-Warmenhoven Apr 13, 2020
f9f10a9
[#1713] removed client/yarn.lock
S-Warmenhoven Apr 13, 2020
7657535
[#1713] created separate class for extracting MomentKeywords
S-Warmenhoven Apr 13, 2020
783d2b7
[#1713] refactored gsub to account for international locale characters
S-Warmenhoven Apr 14, 2020
061cf03
[#1713] moment_keywords basic rspec test
S-Warmenhoven Apr 15, 2020
44d1025
[#1713] added moment categories to moment_keywords test
S-Warmenhoven Apr 15, 2020
f5c1c7d
[#1713] added moment moods to moment_keywords test
S-Warmenhoven Apr 15, 2020
1bf8259
[#1713] added moment strategies to moment_keywords test
S-Warmenhoven Apr 15, 2020
512cf01
[#1713] initial framework for resource_recommendation tests
S-Warmenhoven Apr 15, 2020
ad522be
[#1713] test extracting all resources
S-Warmenhoven Apr 15, 2020
38463df
[#1713] added test for unmatched resources
S-Warmenhoven Apr 16, 2020
585b314
[#1713] test for underscored tags
S-Warmenhoven Apr 16, 2020
9df3d5f
[#1713] test special character keywords
S-Warmenhoven Apr 16, 2020
8992c62
[#1713] code clean-up
S-Warmenhoven Apr 16, 2020
1679668
[#1713] refactored multilined blocks
S-Warmenhoven Apr 16, 2020
34ca73d
[#1713] changed subject to let for non-tested class
S-Warmenhoven Apr 16, 2020
d20a788
[#1713] changed let to subject for class being tested
S-Warmenhoven Apr 16, 2020
0d77421
[#1713] added missing new lines
S-Warmenhoven Apr 16, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[ifmeorg#1713] refactored gsub to account for international locale ch…
…aracters
  • Loading branch information
S-Warmenhoven committed Apr 14, 2020
commit 783d2b7502551ea4d7e98ebe82075e3f035ce184
2 changes: 1 addition & 1 deletion app/services/moment_keywords.rb
Original file line number Diff line number Diff line change
@@ -41,7 +41,7 @@ def get_keywords(array)
def modify_keywords
@moment_keywords = @moment_keywords.flatten
@moment_keywords.each do |keyword|
keyword.gsub!(%r{([_@#!%()\-=;><,{}\~\[\]\./\?\"\*\^\$\+\-]+)}, '')
keyword.gsub!(/[^\p{Alpha} -]/, '')
end
@moment_keywords = @moment_keywords.map(&:downcase)
end