Fix issue ActivityNotFoundException on Utils#openURL #3963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code had a bug that makes an ActivityNotFoundException when a user tries to open a URL on a system with any browser enabled, which is common on Oculus devices, for instance. This commit uses PackageManager to check if there is any webview enabled. It includes the following changes: - Added PackageManager query to find a match with any enabled webview. - Starts the activity only if there is a match. - Logs a warning when there is no webview. - Displays a Toast message indicating that no browser is available. - Added some translations of the message This fix resolves the reported bug and improves the overall user experience when opening URLs. Fixes: TeamAmaze#3756
|
@TranceLove What do you think of these changes? |
VishnuSanal
previously approved these changes
Oct 24, 2023
There was a problem hiding this comment.
awesome work, thanks for fixing this!
PS: we do not encourage adding translations directly to the code. please use Transifex for translations. @VishalNehra please verify whether we can merge it as is, or should these changes be reverted?
VishalNehra
previously approved these changes
Oct 30, 2023
VishalNehra
dismissed stale reviews from VishnuSanal and themself
via
093ae42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code had a bug that makes an ActivityNotFoundException when a user tries to open a URL on a system with any browser enabled, which is common on Oculus devices, for instance. This commit uses PackageManager to check if there is any webview enabled. It includes the following changes:
This fix resolves the reported bug and improves the overall user experience when opening URLs.
Description
Issue tracker
Fixes: #3756
Automatic tests
Manual tests
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck