[FEAT/#90] 인증 동네 삭제 API 구현 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gahyuun
reviewed
Feb 19, 2025
| boolean existsByMemberIdAndName(Long memberId, String name); | ||
|
|
||
| Optional<VerifiedAreaEntity> findById(Long id); |
There was a problem hiding this comment.
Q2: 해당 메서드를 꼭 명시해 줘야 하나요!? findById는 직접 작성하지 않아도 JpaRepository에 존재하는 거 아니었나요!?
There was a problem hiding this comment.
어머 마자요 orElseThrow 메서드 만드는 데만 집중하느라 까묵은 마이 미스테이크 .. 수정해놓겠습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Issue
📸 Screenshot
📄 Description
💬 To Reviewers
MemberId에 해당하는VerifiedAreaEntity들을findAll해서List size를 계산하는 방식에서 JPA 메서드 중countBy를 사용하는 방식으로 변경했습니다.