-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT/#87] 인증 동네 리스트 조회 구현 #88
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4b652a9
chore: 동네 인증 엔드 포인트 변경 (#87)
gahyuun 6dd8a1c
Merge branch 'develop' of https://github.com/TeamACON/ACON-SERVER int…
gahyuun 00fa8cb
Merge branch 'develop' of https://github.com/TeamACON/ACON-SERVER int…
gahyuun 15d5369
fix: 동네 인증 여러 동 가능하게 수정 (#87)
gahyuun 8b478b3
feat: 인증 동네 조회 API 구현 (#87)
gahyuun e478457
fix: size 네이밍 추가 및 정적 팩토리 메서드 사용 (#87)
gahyuun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...member/api/request/MemberAreaRequest.java → ...mber/api/request/VerifiedAreaRequest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
src/main/java/com/acon/server/member/api/response/VerifiedAreaListResponse.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
package com.acon.server.member.api.response; | ||
|
||
import java.util.List; | ||
|
||
public record VerifiedAreaListResponse( | ||
List<VerifiedAreaResponse> verifiedAreaList | ||
) { | ||
|
||
} |
6 changes: 3 additions & 3 deletions
6
...mber/api/response/MemberAreaResponse.java → ...er/api/response/VerifiedAreaResponse.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
package com.acon.server.member.api.response; | ||
|
||
public record MemberAreaResponse( | ||
public record VerifiedAreaResponse( | ||
Long id, | ||
String name | ||
) { | ||
|
||
public static MemberAreaResponse of( | ||
public static VerifiedAreaResponse of( | ||
final Long id, | ||
final String name | ||
) { | ||
return new MemberAreaResponse(id, name); | ||
return new VerifiedAreaResponse(id, name); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2:
VerifiedAreaListResponse 내부에 VerifiedArea를 만들어서 사용하는 것보다 이미 있는 VerifiedAreaResponse를 사용하는 건 어떨까요? (제안)
new를 통한 객체 생성보다는 정적 팩토리 메서드 방식으로 바꿔주면 좋을 것 같아용
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e478457
수정했습니당