-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] 공지사항 등록 API #9
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
closed #7
📝 작업 내용
user또한 DB에 테스트 유저 (idx 값 : 1 ) 1명을 만들어서 테스트 하였습니다.
💬리뷰 요구사항
클라이언트한테 어떻게 이미지를 받을지 몰라서 일단은 클라이언트가 파일을 보내면 이미지 업로드하는 api를 호출해서
url을 클라이언트가 얻으면, 이 url을 request로 받아 공지로 등록할 수 있도록 구현하였습니다.)
-> 아 이 부분 생각해봤는데 파일을 보내면 업로드하는 api를 호출하는 것 자체가 불필요하다고 생각하여 그냥 request로 파일을 받으면 로직에서 s3에 업로드하여 url로 저장할 수 있도록 수정하겠습니다 !!