Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#67 LogBack 설정 #68

Merged
merged 8 commits into from
Jul 28, 2023
Merged

Feat/#67 LogBack 설정 #68

merged 8 commits into from
Jul 28, 2023

Conversation

PgmJun
Copy link
Member

@PgmJun PgmJun commented Jul 24, 2023

✒️ 관련 이슈번호

🔑 Key Changes

  1. 내용
    • 로그백 설정 PR입니다!! 문제있는 부분 있으면 리뷰남겨주세여!

📢 To Reviewers

  • Java Config로 관리하는 방식은 레퍼런스가 찾기 굉장히 어려워서 우선 이렇게 하고 추후에 변경하는걸로 해요!!

@PgmJun PgmJun requested a review from sookyungg July 24, 2023 14:57
@PgmJun PgmJun self-assigned this Jul 24, 2023
@PgmJun PgmJun requested review from orijoon98 and sookyungg and removed request for sookyungg and orijoon98 July 24, 2023 15:02
.gitignore Outdated
firebase_service_key.json!/log/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 어떤 파일인가요?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

띠용 이친구는 깃이그노어 설정중 생긴 오타인 것 같네요!! 처리했습니다!

.gitignore Outdated
@@ -4,6 +4,7 @@ build/
!gradle/wrapper/gradle-wrapper.jar
!src/main/**/build/
!src/test/**/build/
**/*.log
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log 파일 dev 랑 prod 환경에서만 등록하도록 한 거 맞으면 없어도 될 것 같아욤!!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예리하셔라~!

Comment on lines 27 to 44
<springProfile name="local">
<logger name="com.chiwawa.lionheart" level="DEBUG" />
<root level="INFO">
<appender-ref ref="CONSOLE" />
</root>
</springProfile>
<springProfile name="dev">
<root level="INFO">
<appender-ref ref="CONSOLE" />
<appender-ref ref="FILE" />
</root>
</springProfile>
<springProfile name="prod">
<root level="INFO">
<appender-ref ref="CONSOLE" />
<appender-ref ref="FILE" />
</root>
</springProfile>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local 의 경우에는 로그 전부 확인하면서 개발해야 하니 레벨을 trace 로 설정하면 어떨까 싶습니당!!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉 글으네요 좋습니다~!!

@PgmJun PgmJun merged commit 9ab21d7 into develop Jul 28, 2023
2 checks passed
@orijoon98 orijoon98 deleted the feat/#67 branch July 31, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LogBack 붙이기
2 participants