chore(teacher) : lectureId가 0일 때 요청 보내지 않기

Team-Growing · Nov 15, 2023 · c83d6a2 · c83d6a2 · vercel · Nov 15, 2023
1 parent 80fd5ba
commit c83d6a2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/apps/teacher/src/repositories/AttendanceRepository/AttendanceRepository.ts b/apps/teacher/src/repositories/AttendanceRepository/AttendanceRepository.ts
@@ -7,7 +7,7 @@ import {
 
 export interface AttendanceRepository {
   attendanceLecture({ code, lectureId }: AttendLectureParam): Promise<Response>;
-  getAttendanceCode(lectureId: number): Promise<AttendanceCode>;
+  getAttendanceCode(lectureId: number): Promise<AttendanceCode | void>;
   getAttendance({ lectureId, memberId }: AttendMemberParam): Promise<Response>;
   postConfirmAttendance(param: ChangeAttendanceStatusParam): Promise<Response>;
   deleteCancelAttdendance(

diff --git a/apps/teacher/src/repositories/AttendanceRepository/AttendanceRepositoryImpl.ts b/apps/teacher/src/repositories/AttendanceRepository/AttendanceRepositoryImpl.ts
@@ -23,9 +23,13 @@ class AttendanceRepositoryImpl implements AttendanceRepository {
     return data;
   }
 
-  public async getAttendanceCode(lectureId: number): Promise<AttendanceCode> {
-    const { data } = await apiClient.get(`/attendance/code/${lectureId}`);
-    return data;
+  public async getAttendanceCode(
+    lectureId: number
+  ): Promise<AttendanceCode | void> {
+    if (lectureId !== 0) {
+      const { data } = await apiClient.get(`/attendance/code/${lectureId}`);
+      return data;
+    }
   }
 
   public async getAttendants(