Fix duplicate watched status in trakt (due to movie in multiple Plex libraries)

[simonc56]

The idea of this PR :
The trakt watched_movies list used during sync is created when syncing the first movie of the first library.
It is later read to know the watched status of other movies, but it is memoized so not fetched from trakt server. Therefore, it can give a wrong not-watched status when a movie is scanned for the second time in the same sync session.

The idea is to update this list each time a movie is marked as watched in trakt.
With this list up-to-date, the script will know the correct watched status of a movie even if it has already been scanned in the same session.

PlexTraktSync/plex_trakt_sync/trakt_api.py

Lines 90 to 98 in 83ded35

	@property
	@memoize
	@nocache
	@rate_limit()
	def watched_movies(self):
	return set(
	map(lambda m: m.trakt, self.me.watched_movies)
	)

fixes #476

[glensc]

I'm not sure if I really should remove the memoize decorator.

read my response:

• Fix duplicate watched status in trakt (due to movie in multiple Plex libraries) #477 (comment)

without it operates on a copy:

        print(type(trakt.watched_movies))
        print(3 in trakt.watched_movies)
        print(3000 in trakt.watched_movies)
        print(len(trakt.watched_movies))
        trakt.watched_movies.add(3)
        trakt.watched_movies.add(3000)
        print(3 in trakt.watched_movies)
        print(3000 in trakt.watched_movies)
        print(len(trakt.watched_movies))

<class 'set'>
True
False
859
True
False
859

compare with and without the decorator yourself.

[glensc]

and please, try not to force push during the review. use git fixup commits instead. use issue status Draft to prevent accidental merges.

first it's difficult to see the new changes you make, if you overwrite everything each time, and github has troubles as well, as all line comments get hidden somewhere. the comments i left are no longer in context of the lines i commented.

I recommend using git fixup (a simple wrapper for git commit --fixup):

• https://github.com/keis/git-fixup

my typical flow is like this:

git add -p
git fixup HEAD # or git commit --fixup HEAD
git push

and when done with the review (or just too messy and want to clean up):

git fetch
git rebase -i origin/main
git push --force-with-lease

[simonc56]

Ok thanks, i'll have to learn this.

[glensc]

4b01dcb looks accurate now. lets wait for user feedback.

[glensc]

Some of the discussion is on the commit:

• 694bd79#commitcomment-56065708

that discussion is not reachable from pull request due force pushes. at least i can't find it.