Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit hooks (validate-pyproject v0.23) #2191

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Conversation

glensc
Copy link
Collaborator

@glensc glensc commented Feb 21, 2025

@glensc glensc self-assigned this Feb 21, 2025
@glensc glensc merged commit d8f731f into Taxel:main Feb 21, 2025
4 checks passed
@glensc glensc deleted the pep639 branch February 21, 2025 03:51
@glensc
Copy link
Collaborator Author

glensc commented Feb 27, 2025

It actually failed:

    raise ValueError(f"{error}\n{summary}") from None
ValueError: invalid pyproject.toml config: `project.license`.
configuration error: `project.license` must be valid exactly by one definition (2 matches found):

    - keys:
        'file': {type: string}
      required: ['file']
    - keys:
        'text': {type: string}
      required: ['text']

@glensc
Copy link
Collaborator Author

glensc commented Feb 27, 2025

@hugovk: Can you help me to figure out what went wrong?

@glensc
Copy link
Collaborator Author

glensc commented Feb 27, 2025

Ah,

17 commits to unstable/v1 since this release

So it's not included in @release/v1... ?

@glensc
Copy link
Collaborator Author

glensc commented Feb 27, 2025

@hugovk
Copy link

hugovk commented Feb 28, 2025

You're using setuptools as the build backend:

build-backend = "setuptools.build_meta"

setuptools doesn't yet support the new PEP 639 licence metadata, but they're working on it right now:

pypa/setuptools#4829

I'm using hatchling:

https://github.com/hugovk/humanize/blob/6427174e3300a9bbb59558ea47a6fc7b03cb3015/pyproject.toml#L2

glensc added a commit to glensc/PlexTraktSync that referenced this pull request Mar 3, 2025
@glensc
Copy link
Collaborator Author

glensc commented Mar 3, 2025

Reverted until setuptools is updated or switching to hatchling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants