Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Use pluggy framework to extract Sync to plugins #1892

Merged
merged 24 commits into from
Apr 11, 2024

Conversation

glensc
Copy link
Collaborator

@glensc glensc commented Apr 8, 2024

Why: The logic in Sync has be come complicated.

Extra: Possible runtime speedup:
Using plugins can skip checks of every media by if plugin for some feature not enabled at all.

NOTE: WatchListPlugin is still too complicated: contains two watchlist sync logics

@glensc glensc force-pushed the pluggin branch 4 times, most recently from 564faac to 0a86d09 Compare April 10, 2024 05:52
@glensc glensc marked this pull request as ready for review April 10, 2024 05:56
@glensc glensc force-pushed the pluggin branch 4 times, most recently from 0839a11 to f6fdc62 Compare April 10, 2024 06:26
@glensc
Copy link
Collaborator Author

glensc commented Apr 10, 2024

side-effect:

  1. Pugin all class methods are resolved: method: object = getattr(plugin, name), this results all @cached_property being resolved at register() time.

bug:

  1. plugin methods declared with @hookimpl, using default values makes those values being "invisible": they never get assigned a value, their default value is always used.

@glensc glensc merged commit a285dff into Taxel:main Apr 11, 2024
3 checks passed
@glensc glensc deleted the pluggin branch April 11, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant