Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Add Ratings class to support rated_at #1821

Merged
merged 25 commits into from
Feb 24, 2024
Merged

Refactor: Add Ratings class to support rated_at #1821

merged 25 commits into from
Feb 24, 2024

Conversation

glensc
Copy link
Collaborator

@glensc glensc commented Feb 22, 2024 •
edited
Loading

Requires:

NOTE: Plex does not support setting rated_at timestamp, but it provides lastRatedAt attribute.

Fixes #1805

@glensc glensc self-assigned this Feb 22, 2024
@glensc glensc mentioned this pull request Feb 22, 2024
Merged
@glensc glensc mentioned this pull request Feb 22, 2024
Closed
3 tasks
@glensc glensc marked this pull request as ready for review February 22, 2024 16:55
@glensc glensc requested a review from simonc56 February 22, 2024 16:56
glensc added 22 commits February 23, 2024 18:17
@glensc
Pass rated_at parameter to trakt rate
6a21dab
@glensc
Copy rate date for imdb import
29c748e
@glensc
Use plex lastRatedAt to set rated_at
74b77a6
@glensc
Add Rating named tuple
0fbc967
@glensc
Use == to compare ratings
d87ff86
@glensc
Add eq operator to Rating class
5db4cf4
@glensc
Cast ratings to int when comparing
368864d
@glensc
Fill real types for Rating properties
50df693
@glensc
Refactor ratings to use Rating class
192319f
@glensc
Add Rating.create to convert values if needed
e72a98c
@glensc
Simplify types as they are cast first
1d84949
@glensc
Use Rating.create to create the Rating object
79021a6
@glensc
Return None for rating==None
5a6eb9d
@glensc
Simplify code now that Rating.create may return None
f8b914d
@glensc
Add test for Rating class
0d56f40
@glensc
Add None test
4b84044
@glensc
Add test for iso format input
4f0d11f
@glensc
Handle iso str parse for older Python < 3.11
9c8c396
@glensc
Add str for Rating class
9350f9f
@glensc
Allow comparing Rating with numbers
d9d6087
@glensc
Round numbers to int
da890ef
@glensc
Rating can't be None
b0a4d72 
The create method will return None rather Rating with None rating
simonc56
simonc56 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@simonc56 simonc56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@glensc glensc merged commit 476b63c into Taxel:main Feb 24, 2024
3 checks passed
@glensc glensc deleted the Rating-tuple branch February 24, 2024 09:06
@glensc
Copy link
Collaborator Author

glensc commented Feb 24, 2024

i guess lets make next non-patch release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonc56 simonc56 simonc56 approved these changes

Assignees

@glensc glensc

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@glensc @simonc56