Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Optimize resolve_guid to check only once positive providers #1750

Merged
merged 3 commits into from
Jan 20, 2024

Conversation

glensc
Copy link
Collaborator

@glensc glensc commented Jan 17, 2024

The refactor checks provider only once for providers that exist, possible micro performance boost. For unmatched more checks are performed. Previously all checks were performed regardless if the result will fail. It also improves readability of the resolve_guid method and moves logic of deciding which provider is what to PlexGuid class for enculapsing logic there.

Requires:

@glensc glensc self-assigned this Jan 17, 2024
@glensc glensc marked this pull request as ready for review January 17, 2024 17:45
@glensc glensc merged commit 496a212 into Taxel:main Jan 20, 2024
3 checks passed
@glensc glensc deleted the skip-reasons branch January 20, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant