feat: 메뉴 판매량 및 재고 기록 CRUD 작성 #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djdongjae
reviewed
Jun 16, 2024
Comment on lines
+1
to
+27
| package net.skhu.tastyinventory_be.config; | ||
|
|
||
| import org.springframework.beans.factory.annotation.Value; | ||
| import org.springframework.context.annotation.Configuration; | ||
| import org.springframework.http.HttpMethod; | ||
| import org.springframework.web.servlet.config.annotation.CorsRegistry; | ||
| import org.springframework.web.servlet.config.annotation.WebMvcConfigurer; | ||
|
|
||
| @Configuration | ||
| public class MvcConfigurer implements WebMvcConfigurer { | ||
| @Value("${client.origins}") | ||
| private String[] allowedOrigins; | ||
|
|
||
| @Override | ||
| public void addCorsMappings(CorsRegistry registry) { | ||
| registry.addMapping("/**") | ||
| .allowedOrigins(allowedOrigins) | ||
| .allowedMethods( | ||
| HttpMethod.GET.name(), | ||
| HttpMethod.HEAD.name(), | ||
| HttpMethod.POST.name(), | ||
| HttpMethod.PUT.name(), | ||
| HttpMethod.DELETE.name()) | ||
| .maxAge(3600) | ||
| .allowCredentials(true); | ||
| } | ||
| } |
There was a problem hiding this comment.
이 부분 다시 주석 처리! cors 에러는 요청에 헤더를 추가하는 과정이라서 nginx랑 spring에서 cors 처리 이중으로 하면 충돌 남..ㅇㅇ 이거는 로컬에서 리액트랑 스프링 같이 테스트할 때만 써주세여
|
|
||
| protected void setId(Long id) { | ||
| this.id = id; | ||
| } |
There was a problem hiding this comment.
이 부분 어쩌다가 들어갔지요? id 값은 보통 한 번 생성되면 불변인데..?
There was a problem hiding this comment.
아 id를 받아야했어서 생성했었긴 한데 수정해볼게여
| @@ -26,9 +30,13 @@ public class Sold extends BaseEntity { | |||
| private Long count; | |||
|
|
|||
| @Builder | |||
| public Sold(LocalDate date, Menu menu, Long count) { | |||
| public Sold(Long id, LocalDate date, Menu menu, Long count) { | |||
| this.setId(id); | |||
There was a problem hiding this comment.
여기가 원인인듯? 생성자에 id 없어도 됩니당
| @@ -20,6 +27,8 @@ public class SoldService { | |||
| private final SoldRepository soldRepository; | |||
| private final MenuRepository menuRepository; | |||
|
|
|||
| private static final Logger logger = LoggerFactory.getLogger(SoldService.class); | |||
|
|
|||
There was a problem hiding this comment.
로그 확인은 그냥 간단하게 @Slf4j 쓰면 돼
|
아 나도 그거땜에 사실 update부분이 좀 걸렸는데 잘 안돼서 이게 아닌가 싶어서 그냥 id받아서 update로 구현했거든. api는 일단 포스트맨에 있업!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 관련 이슈
📋 구현 기능 명세
메뉴 판매량 등록
[메뉴 판매량 조회](https://www.notion.so/5d66a464bca747818e594d6daa9016b8?pvs=21)
[메뉴 판매량 수정](https://www.notion.so/ada80affc2774fe3b2d2b54e117b67b0?pvs=21)
[메뉴 판매량 삭제](https://www.notion.so/a43b628f7802484e99cd8813b83a4d23?pvs=21)
[실제 재고 기록](https://www.notion.so/96b178a0e98743af986d7aeda95f61b8?pvs=21)
[실제 재고 조회](https://www.notion.so/407898197dc341d49d38822343e698e6?pvs=21)
[실제 재고 수정](https://www.notion.so/60d30999796844e8a1635ffc2576ba03?pvs=21)
[실제 재고 삭제](https://www.notion.so/c568b8baad684f3f93145f51c95f2b6e?pvs=21)
📌 PR Point
무슨 이유로 어떻게 코드를 변경했는지
어떤 부분에 리뷰어가 집중해야 하는지
개발하면서 어떤 점이 궁금했는지
📸 결과물 스크린샷
ㄱ## 🚩 관련 이슈
📋 구현 기능 명세
메뉴 판매량 등록
[메뉴 판매량 조회](https://www.notion.so/5d66a464bca747818e594d6daa9016b8?pvs=21)
[메뉴 판매량 수정](https://www.notion.so/ada80affc2774fe3b2d2b54e117b67b0?pvs=21)
[메뉴 판매량 삭제](https://www.notion.so/a43b628f7802484e99cd8813b83a4d23?pvs=21)
[실제 재고 기록](https://www.notion.so/96b178a0e98743af986d7aeda95f61b8?pvs=21)
[실제 재고 조회](https://www.notion.so/407898197dc341d49d38822343e698e6?pvs=21)
[실제 재고 수정](https://www.notion.so/60d30999796844e8a1635ffc2576ba03?pvs=21)
[실제 재고 삭제](https://www.notion.so/c568b8baad684f3f93145f51c95f2b6e?pvs=21)
📌 PR Point
무슨 이유로 어떻게 코드를 변경했는지
어떤 부분에 리뷰어가 집중해야 하는지
개발하면서 어떤 점이 궁금했는지
📸 결과물 스크린샷
ㄱ
🛠️ 테스트
🚀 API Endpoint