Fixes for clang scan with libarchive imports #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This builds on #528 to address some warnings from clang-scan, by backporting a few libarchives commits. |
gperciva
force-pushed
the
clang-scan-libarchive-imports
branch
from
6772a69 to
13c5653
Compare
This is libarchive's:
2009-11-08
- Value stored to 'data' is never read. - Value stored to 'data_length' is never read.
Found by Clang Static Analyzer.
SVN-Revision: 1620
libarchive/libarchive@c062e1b
Reported by: clang scan-build
This is from libarchive's
2009-12-15
Fix Issue 56: Don't crash when reading an mtree input with "content=."
4e9fd5af1276d7b89ca4ccac025fc835e28f5a9c
SVN-Revision: 1741
libarchive/libarchive@4e9fd5a
The other part of that commit is adding a test case to libarchive, which
we don't need.
Reported by: clang scan-build
This is libarchive's:
2013-05-29
Rework the sign-extension to avoid left-shift of an explicit negative number (which newer GCC complains about).
libarchive/libarchive@533e8fd
Reported by: clang scan-build
gperciva
force-pushed
the
clang-scan-libarchive-imports
branch
from
13c5653 to
d9b4fc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.