standalone-enc: move fd_drain() to a separate file #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's useful to share At the moment it's only used in |
gperciva
commented
Jan 14, 2025
| * Drain bytes from the file descriptor ${*fd_p} -- passed as an (int *) -- as | ||
| * quickly as possible. | ||
| */ | ||
| int fd_drain(void *); |
There was a problem hiding this comment.
My original intent was only to expose fd_drain_fork(), but standalone_transfer_noencrypt.c uses threads rather than processes, so it needs to call fd_drain() directly.
|
This has no impact on the perftest timings. When I first glanced at it with N=5 it looked like it did, but repeating the test with N=11 and then N=31 showed it was a fluke. |
gperciva
force-pushed
the
standalone-fd-drain
branch
from
5407ce1 to
2133364
Compare
- rename pipe_output() to fd_drain() - rename MAXOUTSIZE to FD_DRAIN_MAX_SIZE - use (int *) instead of (struct pipeinfo) - add fd_drain_fork_start()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.