fix: add size property to button loading component #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amir78729
reviewed
Aug 12, 2024
Comment on lines
+70
to
+72
| <tap-spinner | ||
| size=${this.size === 'small' ? 'small' : nothing} | ||
| ></tap-spinner> |
There was a problem hiding this comment.
I think both the button and spinner components have the property size with the type of 'small' | 'medium' | 'large'. Can't we pass the size of the button to the spinner?
Suggested change
| <tap-spinner | |
| size=${this.size === 'small' ? 'small' : nothing} | |
| ></tap-spinner> | |
| <tap-spinner size=${this.size}></tap-spinner> |
There was a problem hiding this comment.
No, because the sizes of the two components do not correspond one-to-one. Buttons labeled 'large' and 'medium' have a spinner with a 'medium' size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.