txlog handle internal error #101

TanmoySG · Apr 22, 2023 · 6bc59a6 · 6bc59a6
1 parent f69590e
commit 6bc59a6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/internal/server/handlers/collection.go b/internal/server/handlers/collection.go
@@ -108,6 +108,6 @@ func (wh wdbHandlers) DeleteCollection(c *fiber.Ctx) error {
 		return err
 	}
 
-	go  wh.handleTransactions(c, resp, entities)
+	go wh.handleTransactions(c, resp, entities)
 	return nil
 }
diff --git a/internal/server/handlers/common.go b/internal/server/handlers/common.go
@@ -99,7 +99,6 @@ func validateRequest(request any) *er.WdbError {
 }
 
 func (wh wdbHandlers) handleTransactions(c *fiber.Ctx, apiResponse response.ApiResponse, entities model.Entities) {
-	var err error
 	if txlogs.IsTxnLoggable(apiResponse.Response.Action) {
 		if apiResponse.Response.Status == response.StatusSuccess {
 			databaseEntity := *entities.Databases
@@ -117,12 +116,15 @@ func (wh wdbHandlers) handleTransactions(c *fiber.Ctx, apiResponse response.ApiR
 			}
 
 			txnLog := txlogs.CreateTxLog(txnAction, txnActor, apiResponse.Response.Status, txnEntityPath, txnHttpDetails)
-			err = wh.wdbTxLogs.Log(txnLog)
+			err := wh.wdbTxLogs.Log(txnLog)
+			if err != nil {
+				log.Errorf("error logging transaction: %s", err)
+			}
+
 			err = wh.wdbTxLogs.Commit()
-
+			if err != nil {
+				log.Errorf("error logging transaction: %s", err)
+			}
 		}
 	}
-	if err != nil {
-		log.Errorf("error logging transaction: %s", err)
-	}
 }