Improved Navigation Bar Color Accessibility for Info, Danger and Dark… #2793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you very much, I like the changes, well documented and understandable! |
vabene1111
approved these changes
Dec 10, 2023
|
thanks again for the PR, due to a recent change in how the nav bar works (setting the color directly) this wont have any effect any more, but still thank you for providing the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2367
Before
After
Explanation of Changes
.bg-darkis a class attribute only present when the Dark Navigation Color is selected and will apply white to the text of the navigation bar..bg-dangerand.bg-infoare class attributes only present when the Danger and Info Navigation Color are selected, respectively.:is(.bg-danger, .bg-info)selects any element with the classbg-dangerorbg-info, and applies a sharper black to the text of the navigation bar.I'm open to feedback on the text color choices or the CSS class selectors used.