Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Update prettier config #5249

Closed
wants to merge 2 commits into from
Closed

style: Update prettier config #5249

wants to merge 2 commits into from

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Jan 1, 2024

Uses the prettier settings common to query, forms, router, etc.

semi: false,
singleQuote: true,
trailingComma: 'all',

@KevinVandy
Copy link
Member

I'd like to do this, but as a result I think we'd have to officially close all of the other stale PRs. And I'd have to start my v9 branch over, though that's not too hard for me.
Most of the remaining open table PRs already have merge conflicts, so maybe it is an ok time to do this.

@lachlancollins
Copy link
Member Author

I'd like to do this, but as a result I think we'd have to officially close all of the other stale PRs. And I'd have to start my v9 branch over, though that's not too hard for me. Most of the remaining open table PRs already have merge conflicts, so maybe it is an ok time to do this.

It's not too hard to apply this change (just change one file and let the command format the rest), so I'd say do it whenever is going to be least inconvenient!

@KevinVandy
Copy link
Member

I think by the end of the week, maybe I am able to make a v9 branch, and we put this config there. This v9 stuff is still kinda iffy if it's going to happen or work, but I've got approval from Tanner to explore some ideas.

@KevinVandy KevinVandy closed this Jan 1, 2024
@lachlancollins lachlancollins deleted the prettier branch January 3, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants