Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derived Scheduler Reimplementation #144

Merged
merged 16 commits into from
Nov 30, 2024

Conversation

crutchcorn
Copy link
Member

@crutchcorn crutchcorn commented Nov 29, 2024

This PR fixes an issue found in this dog-fooding commit: TanStack/form@b79d343

Where prevDepVal is broken due to inaccurate timing of this.prevVal = this.state in Store.

To fix this, we need a more deterministic way of saying:

When all writes of Derived have been made, update the old value of the currently writing store to prevVal

TODOs

  • Make a new batch API that works across stores
  • Fix new .skip test in Derived to prove that Form works
  • Fix everything
  • Update Form with new Derived to fix their (our) tests

@crutchcorn crutchcorn changed the title chore!: remove store.batch, add in temporary scheduler, skip intentio… Derived Scheduler Reimplementation Nov 29, 2024
Copy link

nx-cloud bot commented Nov 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e5c1e4d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Nov 29, 2024

@tanstack/store

npm i https://pkg.pr.new/@tanstack/store@144

@tanstack/solid-store

npm i https://pkg.pr.new/@tanstack/solid-store@144

@tanstack/svelte-store

npm i https://pkg.pr.new/@tanstack/svelte-store@144

@tanstack/react-store

npm i https://pkg.pr.new/@tanstack/react-store@144

@tanstack/angular-store

npm i https://pkg.pr.new/@tanstack/angular-store@144

@tanstack/vue-store

npm i https://pkg.pr.new/@tanstack/vue-store@144

commit: e5c1e4d

@crutchcorn crutchcorn merged commit 782e772 into derived-diamond-problem Nov 30, 2024
3 checks passed
@crutchcorn crutchcorn deleted the refactor-derived-scheduling branch November 30, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant