-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derived Scheduler Reimplementation #144
Merged
crutchcorn
merged 16 commits into
derived-diamond-problem
from
refactor-derived-scheduling
Nov 30, 2024
Merged
Derived Scheduler Reimplementation #144
crutchcorn
merged 16 commits into
derived-diamond-problem
from
refactor-derived-scheduling
Nov 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nally broken tests
crutchcorn
changed the title
chore!: remove store.batch, add in temporary scheduler, skip intentio…
Derived Scheduler Reimplementation
Nov 29, 2024
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e5c1e4d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
…tack/store into refactor-derived-scheduling
@tanstack/store
@tanstack/solid-store
@tanstack/svelte-store
@tanstack/react-store
@tanstack/angular-store
@tanstack/vue-store
commit: |
…tack/store into refactor-derived-scheduling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue found in this dog-fooding commit: TanStack/form@b79d343
Where
prevDepVal
is broken due to inaccurate timing ofthis.prevVal = this.state
inStore
.To fix this, we need a more deterministic way of saying:
TODOs
batch
API that works across stores.skip
test in Derived to prove that Form worksForm
with new Derived to fix their (our) tests