Refactor: Move core SSR functions into its own packages #4495
+3,354
−1,188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schiller-manuel as discussed in #4429. Herewith proposed refactor of the generic SSR functions into its own packages |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
View your CI Pipeline Execution ↗ for commit 06b39e4.
☁️ Nx Cloud last updated this comment at |
|
Apologies for the pipeline failures. Hope the lock file was the last of the build issues. Tests and builds run fine locally. |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-ssr
@tanstack/react-router-with-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-plugin
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-ssr-core
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-router-ssr
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-plugin
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-server
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
rename the render functions for `toString` and `toStream` to drop the `react` and `solid` prefixes reactRenderToStream -> renderRouterToStream reactRenderToString -> renderRouterToString
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This centralizes the SSR generic logic into its own package and enables pure Tanstack Router projects to not depend on Start imports for SSR functions.
This should also be non-breaking as all Start core packages either re-exports these or implements its own functionalities.
Going forward this should enable Start specific changes to the rendering functions to be isolated to Start without adversely affecting Router packages/projects that depends on the SSR functionality.
This PR currently adds 2 new packages: router-core-ssr and react-router-ssr. A similar package, to react-router-ssr, can be created for solid-router going forward if required.