Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-router): allow users to override props with their props #2858

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chorobin
Copy link
Contributor

No description provided.

@chorobin chorobin requested a review from TkDodo November 25, 2024 21:23
Copy link

nx-cloud bot commented Nov 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8a8b2e7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:eslint,test:unit,test:e2e,test:types,test:build,build --parallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Nov 25, 2024

Open in Stackblitz

More templates

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@2858

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@2858

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@2858

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@2858

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@2858

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@2858

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@2858

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@2858

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@2858

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@2858

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@2858

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@2858

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@2858

@tanstack/start-vite-plugin

npm i https://pkg.pr.new/@tanstack/start-vite-plugin@2858

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@2858

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@2858

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@2858

commit: 8a8b2e7

Copy link
Contributor

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried out the preview build and it fixes our issue 👏

@TkDodo
Copy link
Contributor

TkDodo commented Dec 6, 2024

@chorobin can we mark this as ready? Is there anything missing you’d like to add?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants