Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(solid-query): implemented infiniteQueryOptions #7404

Merged
merged 5 commits into from
Jun 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 109 additions & 0 deletions packages/solid-query/src/__tests__/createInfiniteQuery.test-d.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,109 @@
import { describe } from 'node:test'
import { expectTypeOf, it } from 'vitest'
import { type InfiniteData, dataTagSymbol } from '@tanstack/query-core'
import {
createInfiniteQuery,
infiniteQueryOptions,
} from '../createInfiniteQuery'
import type {
DefinedInitialDataInfiniteOptions,
UndefinedInitialDataInfiniteOptions,
} from '../createInfiniteQuery'

const doNotRun = (_callback: () => void) => {}

describe('infiniteQueryOptions', () => {
it('should infer defined types', () => {
const options = infiniteQueryOptions({
getNextPageParam: () => 10,
queryKey: ['key'],
queryFn: () => ({ wow: true }),
initialData: {
pageParams: [undefined],
pages: [{ wow: true }],
},
initialPageParam: 0,
})

doNotRun(() => {
expectTypeOf<
InfiniteData<
{
wow: boolean
},
unknown
>
>(createInfiniteQuery(() => options).data)

expectTypeOf<
ReturnType<
DefinedInitialDataInfiniteOptions<
{
wow: boolean
},
Error,
InfiniteData<
{
wow: boolean
},
unknown
>,
Array<string>,
number | undefined
>
>
>(options)

expectTypeOf(options.queryKey[dataTagSymbol]).toEqualTypeOf<
InfiniteData<{ wow: boolean }>
>()
})
})

it('should work without defined types', () => {
const options = infiniteQueryOptions({
getNextPageParam: () => undefined,
queryKey: ['key'],
queryFn: () => ({ wow: true }),
initialPageParam: 0,
})

doNotRun(() => {
expectTypeOf<
() =>
| InfiniteData<
{
wow: boolean
},
unknown
>
| undefined
>(() => createInfiniteQuery(() => options).data)

expectTypeOf<
ReturnType<
UndefinedInitialDataInfiniteOptions<
{
wow: boolean
},
Error,
InfiniteData<
{
wow: boolean
},
unknown
>,
Array<string>,
number
>
>
>(options)

expectTypeOf(options.queryKey[dataTagSymbol]).toEqualTypeOf<
InfiniteData<{
wow: boolean
}>
>()
})
})
})
27 changes: 27 additions & 0 deletions packages/solid-query/src/__tests__/createInfiniteQuery.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {
QueryCache,
QueryClientProvider,
createInfiniteQuery,
infiniteQueryOptions,
keepPreviousData,
} from '..'
import {
Expand Down Expand Up @@ -2056,4 +2057,30 @@ describe('useInfiniteQuery', () => {

await waitFor(() => rendered.getByText('Status: custom client'))
})

it('should work with infiniteQueryOptions', async () => {
const key = queryKey()
const options = infiniteQueryOptions({
getNextPageParam: () => undefined,
queryKey: key,
initialPageParam: 0,
queryFn: () => Promise.resolve(220),
})

function Page() {
const state = createInfiniteQuery(
() => options,
() => queryClient,
)
return (
<div>
<h1>Status: {state.data?.pages[0]}</h1>
</div>
)
}

const rendered = render(() => <Page />)

await waitFor(() => rendered.getByText('Status: 220'))
})
})
138 changes: 138 additions & 0 deletions packages/solid-query/src/createInfiniteQuery.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { InfiniteQueryObserver } from '@tanstack/query-core'
import { createMemo } from 'solid-js'
import { createBaseQuery } from './createBaseQuery'
import type {
DataTag,
DefaultError,
InfiniteData,
QueryKey,
Expand All @@ -11,9 +12,146 @@ import type { QueryClient } from './QueryClient'
import type {
CreateInfiniteQueryOptions,
CreateInfiniteQueryResult,
DefinedCreateInfiniteQueryResult,
FunctionedParams,
SolidInfiniteQueryOptions,
} from './types'
import type { Accessor } from 'solid-js'

export type UndefinedInitialDataInfiniteOptions<
TQueryFnData,
TError = DefaultError,
TData = InfiniteData<TQueryFnData>,
TQueryKey extends QueryKey = QueryKey,
TPageParam = unknown,
> = FunctionedParams<
SolidInfiniteQueryOptions<
TQueryFnData,
TError,
TData,
TQueryFnData,
TQueryKey,
TPageParam
> & {
initialData?: undefined
}
>
type NonUndefinedGuard<T> = T extends undefined ? never : T
export type DefinedInitialDataInfiniteOptions<
TQueryFnData,
TError = DefaultError,
// should we handle page param correctly
TData = InfiniteData<TQueryFnData>,
TQueryKey extends QueryKey = QueryKey,
TPageParam = unknown,
> = FunctionedParams<
SolidInfiniteQueryOptions<
TQueryFnData,
TError,
TData,
TQueryFnData,
TQueryKey,
TPageParam
> & {
initialData:
| NonUndefinedGuard<InfiniteData<TQueryFnData, TPageParam>>
| (() => NonUndefinedGuard<InfiniteData<TQueryFnData, TPageParam>>)
}
>
function infiniteQueryOptions<
TQueryFnData,
TError = DefaultError,
TData = InfiniteData<TQueryFnData>,
TQueryKey extends QueryKey = QueryKey,
TPageParam = unknown,
>(
options: ReturnType<
DefinedInitialDataInfiniteOptions<
TQueryFnData,
TError,
TData,
TQueryKey,
TPageParam
>
>,
): ReturnType<
DefinedInitialDataInfiniteOptions<
TQueryFnData,
TError,
TData,
TQueryKey,
TPageParam
>
> & {
queryKey: DataTag<TQueryKey, InfiniteData<TQueryFnData>>
}
function infiniteQueryOptions<
TQueryFnData,
TError = DefaultError,
TData = InfiniteData<TQueryFnData>,
TQueryKey extends QueryKey = QueryKey,
TPageParam = unknown,
>(
options: ReturnType<
UndefinedInitialDataInfiniteOptions<
TQueryFnData,
TError,
TData,
TQueryKey,
TPageParam
>
>,
): ReturnType<
UndefinedInitialDataInfiniteOptions<
TQueryFnData,
TError,
TData,
TQueryKey,
TPageParam
>
> & {
queryKey: DataTag<TQueryKey, InfiniteData<TQueryFnData>>
}

function infiniteQueryOptions(options: unknown) {
return options
}

export { infiniteQueryOptions }

export function createInfiniteQuery<
TQueryFnData,
TError = DefaultError,
TData = InfiniteData<TQueryFnData>,
TQueryKey extends QueryKey = QueryKey,
TPageParam = unknown,
>(
options: DefinedInitialDataInfiniteOptions<
TQueryFnData,
TError,
TData,
TQueryKey,
TPageParam
>,
queryClient?: Accessor<QueryClient>,
): DefinedCreateInfiniteQueryResult<TData, TError>
export function createInfiniteQuery<
TQueryFnData,
TError = DefaultError,
TData = InfiniteData<TQueryFnData>,
TQueryKey extends QueryKey = QueryKey,
TPageParam = unknown,
>(
options: UndefinedInitialDataInfiniteOptions<
TQueryFnData,
TError,
TData,
TQueryKey,
TPageParam
>,
queryClient?: Accessor<QueryClient>,
): CreateInfiniteQueryResult<TData, TError>

export function createInfiniteQuery<
TQueryFnData,
TError = DefaultError,
Expand Down
9 changes: 8 additions & 1 deletion packages/solid-query/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,14 @@ export {
} from './QueryClientProvider'
export type { QueryClientProviderProps } from './QueryClientProvider'
export { useIsFetching } from './useIsFetching'
export { createInfiniteQuery } from './createInfiniteQuery'
export {
createInfiniteQuery,
infiniteQueryOptions,
} from './createInfiniteQuery'
export type {
DefinedInitialDataInfiniteOptions,
UndefinedInitialDataInfiniteOptions,
} from './createInfiniteQuery'
export { createMutation } from './createMutation'
export { useIsMutating } from './useIsMutating'
export { useMutationState } from './useMutationState'
Expand Down
6 changes: 6 additions & 0 deletions packages/solid-query/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import type {
DefaultError,
DefinedInfiniteQueryObserverResult,
DefinedQueryObserverResult,
InfiniteQueryObserverResult,
MutateFunction,
Expand Down Expand Up @@ -142,6 +143,11 @@ export type CreateInfiniteQueryResult<
TError = DefaultError,
> = InfiniteQueryObserverResult<TData, TError>

export type DefinedCreateInfiniteQueryResult<
TData = unknown,
TError = DefaultError,
> = DefinedInfiniteQueryObserverResult<TData, TError>

/* --- Create Mutation Types --- */
export interface SolidMutationOptions<
TData = unknown,
Expand Down
Loading