Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(solid-query): use vitest typecheck correctly with *.test-d.ts #6986

Merged

Conversation

manudeli
Copy link
Contributor

@manudeli manudeli commented Feb 28, 2024

Reference: https://vitest.dev/guide/testing-types

I convert type testing files as vitest's default *.test-d.tsx file from *.types.test.tsx

image

I am converting *.types.test.ts into vitest *.test-d.ts file one package by one package gradually

Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Feb 29, 2024 1:24pm

Copy link

nx-cloud bot commented Feb 28, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f00f87e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codesandbox-ci bot commented Feb 28, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f00f87e:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@manudeli manudeli marked this pull request as ready for review February 28, 2024 12:30
@TkDodo TkDodo merged commit b311a0a into TanStack:main Mar 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants