Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Tidy up solid-form build, use tsc for lit-form #762

Merged
merged 2 commits into from
Jun 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/angular-form/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"experimentalDecorators": true,
"moduleResolution": "node",
"module": "ES2022",
"types": ["vitest/globals"],
"paths": {
"@tanstack/form-core": ["../form-core/src"]
}
Expand Down
2 changes: 1 addition & 1 deletion packages/lit-form/.eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const config = {
extends: ['plugin:react/recommended', 'plugin:react-hooks/recommended'],
parserOptions: {
tsconfigRootDir: __dirname,
project: './tsconfig.eslint.json',
project: './tsconfig.json',
},
rules: {
'react/jsx-key': ['error', { checkFragmentShorthand: true }],
Expand Down
16 changes: 6 additions & 10 deletions packages/lit-form/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,25 +18,21 @@
"test:lib": "vitest",
"test:lib:dev": "pnpm run test:lib --watch",
"test:build": "publint --strict",
"build": "vite build"
"build": "tsc -p tsconfig.build.json"
},
"files": [
"dist",
"src"
],
"type": "module",
"types": "dist/esm/index.d.ts",
"main": "dist/cjs/index.cjs",
"module": "dist/esm/index.js",
"types": "dist/index.d.ts",
"main": "dist/index.js",
"module": "dist/index.js",
"exports": {
".": {
"import": {
"types": "./dist/esm/index.d.ts",
"default": "./dist/esm/index.js"
},
"require": {
"types": "./dist/cjs/index.d.cts",
"default": "./dist/cjs/index.cjs"
"types": "./dist/index.d.ts",
"default": "./dist/index.js"
}
},
"./package.json": "./package.json"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/// <reference lib="dom" />
import { afterEach, beforeEach, describe, expect, it } from 'vitest'
import '@testing-library/jest-dom'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { TestForm, sampleData } from './simple'

window.customElements.define('test-form', TestForm)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { LitElement, html } from 'lit'
import { TanStackFormController } from '../index.js'
import type { FieldApi, FormOptions } from '../index.js'
import { TanStackFormController } from '../src/index.js'
import type { FieldApi, FormOptions } from '../src/index.js'

interface Employee {
firstName: string
Expand Down
12 changes: 12 additions & 0 deletions packages/lit-form/tsconfig.build.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"extends": "../../tsconfig.json",
"compilerOptions": {
"moduleResolution": "Bundler",
"rootDir": "src",
"outDir": "dist",
"noEmit": false,
"declaration": true,
"sourceMap": true
},
"include": ["src"]
}
7 changes: 0 additions & 7 deletions packages/lit-form/tsconfig.eslint.json

This file was deleted.

9 changes: 2 additions & 7 deletions packages/lit-form/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
{
"composite": true,
"extends": "../../tsconfig.json",
"compilerOptions": {
"lib": ["DOM"],
"outDir": "./build/lib",
"module": "ESNext",
"moduleResolution": "bundler",
"types": ["vitest/globals"]
"moduleResolution": "Bundler"
},
"include": ["src"]
"include": ["src", "tests", ".eslintrc.cjs", "vite.config.ts"]
}
18 changes: 5 additions & 13 deletions packages/lit-form/vite.config.ts
Original file line number Diff line number Diff line change
@@ -1,22 +1,14 @@
import { defineConfig, mergeConfig } from 'vitest/config'
import { tanstackBuildConfig } from '@tanstack/config/build'
import { defineConfig } from 'vitest/config'
import packageJson from './package.json'

const config = defineConfig({
export default defineConfig({
test: {
name: 'lit-form',
dir: './src',
name: packageJson.name,
dir: './tests',
watch: false,
environment: 'jsdom',
globals: true,
coverage: { enabled: true, provider: 'istanbul', include: ['src/**/*'] },
typecheck: { enabled: true },
},
})
export default mergeConfig(
config,
tanstackBuildConfig({
entry: './src/index.ts',
srcDir: './src',
exclude: ['./src/tests'],
}),
)
1 change: 1 addition & 0 deletions packages/solid-form/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
],
"type": "module",
"types": "dist/index.d.ts",
"main": "dist/index.js",
"module": "dist/index.js",
"exports": {
".": {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { assertType, it } from 'vitest'
import { createForm } from '../createForm'
import { createForm } from '../src/createForm'

it('should type state.value properly', () => {
function Comp() {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { describe, expect, it, vi } from 'vitest'
import { render, waitFor } from '@solidjs/testing-library'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import '@testing-library/jest-dom/vitest'
import { Index, Show, createEffect } from 'solid-js'
import { createForm } from '../index'
import { Index, Show } from 'solid-js'
import { createForm } from '../src/index'
import { sleep } from './utils'

const user = userEvent.setup()
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { describe, expect, it, vi } from 'vitest'
import { render, screen, waitFor } from '@solidjs/testing-library'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { Show, createSignal, onCleanup } from 'solid-js'
import { createForm } from '../index'
import { createForm } from '../src/index'
import { sleep } from './utils'
import type { ValidationErrorMap } from '@tanstack/form-core'

Expand Down
13 changes: 6 additions & 7 deletions packages/solid-form/tsconfig.build.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,14 @@
"jsx": "preserve",
"jsxImportSource": "solid-js",
"moduleResolution": "Bundler",
"paths": {
"@tanstack/form-core": ["../../form-core/src"]
},
"rootDir": "src",
"outDir": "dist",
"noEmit": false,
"declaration": true,
"rootDir": "src",
"sourceMap": true
"sourceMap": true,
"paths": {
"@tanstack/form-core": ["../../form-core/src"]
}
},
"include": ["src/**/*.ts", "src/**/*.tsx"],
"exclude": ["src/tests/**"]
"include": ["src"]
}
4 changes: 2 additions & 2 deletions packages/solid-form/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
}
},
"include": [
"src/**/*.ts",
"src/**/*.tsx",
"src",
"tests",
".eslintrc.cjs",
"test-setup.ts",
"vite.config.ts"
Expand Down
3 changes: 1 addition & 2 deletions packages/solid-form/tsconfig.legacy.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,5 @@
"@tanstack/form-core": ["../form-core/src"]
}
},
"include": ["src/**/*.ts", "src/**/*.tsx"],
"exclude": ["src/tests/**"]
"include": ["src"]
}
19 changes: 5 additions & 14 deletions packages/solid-form/vite.config.ts
Original file line number Diff line number Diff line change
@@ -1,25 +1,16 @@
import { defineConfig, mergeConfig } from 'vitest/config'
import { tanstackBuildConfig } from '@tanstack/config/build'
import { defineConfig } from 'vitest/config'
import solid from 'vite-plugin-solid'
import packageJson from './package.json'

const config = defineConfig({
export default defineConfig({
plugins: [solid()],
test: {
name: 'solid-form',
dir: './src',
name: packageJson.name,
dir: './tests',
watch: false,
environment: 'jsdom',
setupFiles: ['test-setup.ts'],
coverage: { enabled: true, provider: 'istanbul', include: ['src/**/*'] },
typecheck: { enabled: true },
},
})

export default mergeConfig(
config,
tanstackBuildConfig({
entry: './src/index.ts',
srcDir: './src',
exclude: ['./src/tests'],
}),
)
Loading