fix: adds IDs to input elements with labels #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding IDs to input elements that have labels in the docs to improve accesibility and be more semantically correct.
This commit adds IDs to the input elements so that they can be appropriately referenced by labels using the 'for' attribute. This is a bugfix that improves the accessibility of the examples and makes it so when yoiu click the label the input gets focused.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Since this messes up the formatting because of that the empty .prettierrc files have not been removed yet I will add another commit to fix that as if they were already removed |
This fixes the formatting for the react examples to be like the global config as if the empty .prettierrc files were missing.
michaelbrusegard
force-pushed
the
add-ids-input
branch
from
f230b3b to
1e6819f
Compare
|
@michaelbrusegard let's merge |
crutchcorn
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds IDs to the input elements with labels so they are referenced correctly using the "for" attribute.
The formatting changes come from the empty .prettierrc files in the examples which override the global config. There will be a secondary PR to fix this, but that is the reason for the semicolons and singlequotes being changed here.