Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly exit publish script #555

Merged
merged 2 commits into from
Jan 5, 2024
Merged

fix: Correctly exit publish script #555

merged 2 commits into from
Jan 5, 2024

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Jan 5, 2024

On successfully finishing the script, this github workflow continued indefinitely: https://github.com/TanStack/form/actions/runs/7419873463

This seems to be an async/await error. I'm expecting this change (https://github.com/TanStack/config/releases/tag/v0.1.7) will allow it to correctly return exit code 0.

I've tweaked the tsconfig file to use "module": "ES2022", since this permits top-level await. This has no impact on the types generated for packages.

Copy link

codesandbox-ci bot commented Jan 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (48e241a) 87.74% compared to head (b7ae3e5) 87.74%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #555   +/-   ##
=======================================
  Coverage   87.74%   87.74%           
=======================================
  Files          31       31           
  Lines         816      816           
  Branches      182      182           
=======================================
  Hits          716      716           
  Misses         95       95           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lachlancollins lachlancollins merged commit 2003e4d into TanStack:main Jan 5, 2024
2 checks passed
@lachlancollins lachlancollins deleted the fix-publish branch January 5, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants