Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unused dependencies and files #553

Merged
merged 1 commit into from
Jan 5, 2024
Merged

fix: Remove unused dependencies and files #553

merged 1 commit into from
Jan 5, 2024

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Jan 5, 2024

  • Used knip to identify packages and files which aren't used anywhere in the repo.
  • Marked as fix since it removes unused dependencies from react-form and vue-form

@lachlancollins lachlancollins changed the title fix: Remove unused dependencies fix: Remove unused dependencies and files Jan 5, 2024
Copy link

codesandbox-ci bot commented Jan 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

Codecov Report

Attention: 71 lines in your changes are missing coverage. Please review.

Comparison is base (c2f9957) 84.55% compared to head (af5ea0d) 87.74%.
Report is 110 commits behind head on main.

Files Patch % Lines
...ckages/solid-form/src/tests/createField.test-d.tsx 0.00% 26 Missing ⚠️
packages/form-core/src/FormApi.ts 91.04% 12 Missing ⚠️
packages/react-form/src/validateFormData.ts 16.66% 8 Missing and 2 partials ⚠️
packages/form-core/src/utils.ts 89.47% 6 Missing ⚠️
packages/form-core/src/FieldApi.ts 95.60% 4 Missing ⚠️
packages/form-core/src/mergeForm.ts 85.71% 3 Missing ⚠️
packages/react-form/src/useField.tsx 85.71% 2 Missing ⚠️
packages/react-form/src/useTransform.ts 0.00% 2 Missing ⚠️
packages/vue-form/src/useForm.tsx 66.66% 2 Missing ⚠️
packages/react-form/src/useIsomorphicEffectOnce.ts 94.11% 1 Missing ⚠️
... and 3 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
+ Coverage   84.55%   87.74%   +3.18%     
==========================================
  Files           9       31      +22     
  Lines         395      816     +421     
  Branches      109      182      +73     
==========================================
+ Hits          334      716     +382     
- Misses         52       95      +43     
+ Partials        9        5       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lachlancollins lachlancollins merged commit b309da7 into TanStack:main Jan 5, 2024
2 checks passed
@lachlancollins lachlancollins deleted the remove-unused branch January 5, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants