Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo: Build with vite #535

Closed
wants to merge 1 commit into from
Closed

Demo: Build with vite #535

wants to merge 1 commit into from

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Dec 29, 2023

Part of the effort to address tsup issues.

Pros:

  • Very popular and maintained build tool
  • Simple configuration

Cons:

  • Bundles everything by default, so need to tell it which dependencies to keep external (or add a plugin)
  • Doesn't generate .d.ts by default, so need a separate tsc task or a separate plugin (which only generates for ESM or CJS - is CJS still necessary?)
  • Feels like it's designed for bundling apps, not libraries

@crutchcorn
Copy link
Member

Superseded by #528 and migrating to Vite

Thanks so much for your help!

@crutchcorn crutchcorn closed this Dec 29, 2023
@lachlancollins lachlancollins deleted the demo-vite-build branch December 29, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants