Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add typescript tests for versions 4.8-5.2 #529

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

aadito123
Copy link
Member

These tests ensure that the repo can still be built with older versions of TypeScript, down to 4.8, but the final build still occurs with 5.2. This should ensure that users don't have breaking builds when using older TS versions.

@aadito123 aadito123 requested a review from crutchcorn December 14, 2023 11:36
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (c2f9957) 84.55% compared to head (327356b) 93.49%.
Report is 91 commits behind head on main.

Files Patch % Lines
packages/form-core/src/FormApi.ts 93.10% 8 Missing ⚠️
packages/form-core/src/FieldApi.ts 96.42% 3 Missing ⚠️
packages/form-core/src/utils.ts 96.07% 2 Missing ⚠️
packages/react-form/src/useField.tsx 75.00% 2 Missing ⚠️
packages/solid-form/src/createField.tsx 96.55% 1 Missing ⚠️
packages/solid-form/src/createForm.tsx 92.30% 1 Missing ⚠️
packages/solid-form/src/formContext.ts 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #529      +/-   ##
==========================================
+ Coverage   84.55%   93.49%   +8.94%     
==========================================
  Files           9       21      +12     
  Lines         395      646     +251     
  Branches      109      156      +47     
==========================================
+ Hits          334      604     +270     
+ Misses         52       39      -13     
+ Partials        9        3       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@crutchcorn crutchcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're a legend, thank you for this!

@crutchcorn crutchcorn merged commit f30ac95 into TanStack:main Dec 14, 2023
5 checks passed
@aadito123 aadito123 deleted the typescript-tests branch December 22, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants